Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deb package target and workflow #422

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add deb package target and workflow #422

wants to merge 3 commits into from

Conversation

gastmaier
Copy link

Generate a deb package, as we already do with libiio.

It is a copy from how libiio generates the deb package, with updated dependencies and a special case for GtkDataBox [1].
It should support Ubuntu version >= 20.04 .

I did not really like libiio's way of generating the debs/rpms, but for cohesion I used the same script.
That being said, I don't think we should ever enable DEB_DETECT_DEPENDENCIES to auto-detect dependencies versions.

The CI is missing, but will probably be very similar to the one in libiio.

[1] In #404 it was suggested to generate debs for the Gtk2 version, but that means to branch from a old commit and create a "legacy" release; instead, I bundled it (140kB) in the deb/rpm (all of its deps are covered by IIO-Oscilloscope dependencies).

Suggestions are welcome.

@gastmaier
Copy link
Author

gastmaier commented Mar 22, 2023

I included the CI with commit 2ed30f7, however libad*-iio is not included in the main Ubuntus repo.
I was thinking to bundle with iio-osc, instead of making the user install 2 more packages.

Edit:
I bundled libad*-iio with f44b844, see run 4493892579.
I still need to test the deb in a fresh container.

@gastmaier gastmaier changed the title Create .deb package target Add deb/rpm package target and workflow Mar 22, 2023
@gastmaier gastmaier changed the title Add deb/rpm package target and workflow Add deb package target and workflow Mar 23, 2023
@gastmaier gastmaier marked this pull request as ready for review March 24, 2023 15:18
@gastmaier
Copy link
Author

Summary of the rebase (5 days ago):

  • Supports Ubuntu 22.04 (v0.15); for Ubuntu 20.04 (v0.14), there is branch ubuntu20.04-v0.14.
  • Uses only packages from the main Ubuntu repository as dependencies.
  • Checks if libad9361 or libad9166 is included, but since only libad9361 is available in the main Ubuntu repository, it is not compiled with libad9166 support.

@gastmaier gastmaier requested a review from dNechita March 28, 2023 11:45
Copy link
Contributor

@dNechita dNechita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will give it a try today or tomorrow and get back to this PR. Thanks!

@SRaus SRaus changed the base branch from master to main January 9, 2024 09:42
@gastmaier gastmaier marked this pull request as draft March 18, 2024 11:58
@gastmaier
Copy link
Author

gastmaier commented Mar 18, 2024

Requires changes to meet new apt repo requirements + wait pkg deps (*-dev) to be stable in the apt.

Include files to generate debs, targeting Ubuntu 22.04.
Uses the ENABLE_PACKAGING cmake flag to generate the packages.
Uses dependencies available in the main package manager repositories.
The workflow runs in master, this branch and on published release.
Can also create rpm, but this is not uploaded by the workflow.
Note: Ubuntu libcurl4 flavor is openssl, rpm generated in Ubuntu
will mostly not work with Fedora/OpenSUSE.

Signed-off-by: Jorge Marques <[email protected]>
Badge will only show status for builds at master branch.

Signed-off-by: Jorge Marques <[email protected]>
Fix deprecated notice.

Signed-off-by: Jorge Marques <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants