-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --noarch-build-subdir option #172
Open
mingwandroid
wants to merge
10
commits into
anaconda-graveyard:master
Choose a base branch
from
mingwandroid:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Dec 3, 2020
-
Add --noarch-build-subdir option
It would be nice to know that we can still build noarch and noarch python on other OSes (well, except Windows at present). This allows that. Also, in combination with --output-dir it allows building locally as would happen on c3i. A sample script to glue this together is: ``` set -e FS_STUB=$1 __conda_setup="$(/opt/conda/bin/conda 'shell.bash' 'hook' 2> /dev/null)" if [ $? -eq 0 ]; then eval "$__conda_setup" fi if [[ $(uname) == Darwin ]]; then BUILD_SUBDIR=osx-64 elif [[ $(uname) =~ M.* ]]; then BUILD_SUBDIR=win-64 else BUILD_SUBDIR=linux-64 fi mkdir /tmp/$$.c3i-locally pushd /tmp/$$.c3i-locally conda activate cp -rf /opt/r/a/$FS_STUB-feedstock . cp -f /opt/r/a/conda_build_config.yaml . c3i one-off rdonnelly.$FS_STUB \ $FS_STUB-feedstock \ --config-root-dir=/opt/asrc/automated-build/c3i_configurations/github_public \ --dry-run \ --output-dir $PWD \ --noarch-build-subdir ${BUILD_SUBDIR} \ --no-skip-existing mkdir rsync-recipes cp -rf *-on-* rsync-recipes/ mkdir stats cmds=$(cat plan.yml | yq -r '.jobs[0].plan[] | select(.task=="build").config.run.args[1]') echo $cmds conda deactivate eval ${cmds} popd ```
Configuration menu - View commit details
-
Copy full SHA for ff58d77 - Browse repository at this point
Copy the full SHA ff58d77View commit details -
Fix multiple recipe copy problem
Ended up causing multiple builds inside of conda-build, one without the CBC file being considered (we ended up with a meta.yaml and also a recipe/meta.yaml because the cp -Rf fallback was incorrect). Most people wouldn't see this problem as it only happens when shutil.copytree() takes exception.
Configuration menu - View commit details
-
Copy full SHA for 6f85bb7 - Browse repository at this point
Copy the full SHA 6f85bb7View commit details -
[WIP] Begin implementing --build-on for one-off mode
.. for local and docker build support. run_plan_yaml() does the work, at the moment, osx builds will get launched via subprocess.check_output() and gets called via submit_local() We need a job loop with dependencies instead and we need to hook this up to docker. Is there a good Python interface to docker?
Configuration menu - View commit details
-
Copy full SHA for fdbb798 - Browse repository at this point
Copy the full SHA fdbb798View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc6ef3 - Browse repository at this point
Copy the full SHA ccc6ef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e4482 - Browse repository at this point
Copy the full SHA c5e4482View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bb837f - Browse repository at this point
Copy the full SHA 9bb837fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27e4daa - Browse repository at this point
Copy the full SHA 27e4daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 741c790 - Browse repository at this point
Copy the full SHA 741c790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5449224 - Browse repository at this point
Copy the full SHA 5449224View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06a581a - Browse repository at this point
Copy the full SHA 06a581aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.