Add subcell limiting for nonconservative systems to the big subcell-limiting branch #5

amrueda · 2023-10-12T12:05:24Z

No description provided.

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.16.9 to 1.16.15. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.16.9...v1.16.15) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

…#1651) * update overview.md * add note on parabolic terms

* Use Analysis CB * Apply suggestions from code review --------- Co-authored-by: Hendrik Ranocha <[email protected]>

…mework#1658)

* Fix mapping string in `StructuredMesh` * `eval` full string to avoid using `Meta.parseall` * Make `mapping_as_string` consistent --------- Co-authored-by: Hendrik Ranocha <[email protected]>

…work#1656) * Avoid allocations due to usage of broadcasting operation * Comments & correcting copy-paste error --------- Co-authored-by: Hendrik Ranocha <[email protected]>

…ative systems -> A working version of this implementation is added for the GLM-MHD system -> The flux-differencing formula requires non-conservative terms of the form (local * symmetric)... I modified equations/ideal_glm_mhd_2d.jl and solvers/dgsem_tree/dg_2d.jl to make it work -> In this first implementation, we only use the Powell term and deactivate the GLM term

…2d.jl back to its original state

…erms for `P4estMesh{2}` (trixi-framework#1553) * Adding parabolic Dirichlet boundary condition example * add test * Correcting the format * Update src/equations/compressible_navier_stokes_2d.jl Co-authored-by: Jesse Chan <[email protected]> * Update src/equations/compressible_navier_stokes_2d.jl Co-authored-by: Jesse Chan <[email protected]> --------- Co-authored-by: Jesse Chan <[email protected]> Co-authored-by: Hendrik Ranocha <[email protected]>

…ve terms

…he modified Powell source term. This was needed due to incompatibility on non-conforming meshes.

…rk#1668) * fix bug in parabolic jacobian computations * formatting * updating test results and removing duplicate test --------- Co-authored-by: Hendrik Ranocha <[email protected]>

* show percentage of simulation progress * add notes about AnalysisCallback in docs * generalize for general initial time --------- Co-authored-by: Hendrik Ranocha <[email protected]>

Co-authored-by: Hendrik Ranocha <[email protected]>

…nservative and fixed some conflicts

github-actions · 2023-10-12T12:05:44Z

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

The PR has a single goal that is clear from the PR title and/or description.
All code changes represent a single set of modifications that logically belong together.
No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

The code can be understood easily.
Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
There are no redundancies that can be removed by simple modularization/refactoring.
There are no leftover debug statements or commented code sections.
The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

New functions and types are documented with a docstring or top-level comment.
Relevant publications are referenced in docstrings (see example for formatting).
Inline comments are used to document longer or unusual code sections.
Comments describe intent ("why?") and not just functionality ("what?").
If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

The PR passes all tests.
New or modified lines of code are covered by tests.
New or modified tests run in less then 10 seconds.

Performance

There are no type instabilities or memory allocations in performance-critical parts.
If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

The correctness of the code was verified using appropriate tests.
If new equations/methods are added, a convergence test has been run and the results
are posted in the PR.

Created with ❤️ by the Trixi.jl community.

…ork#1649) * Implement order of bounds as Dict * Implement `variable_bounds` directly as Dictionary * Remove unnecessary line of code * Use Symbols instead of Strings

dependabot bot and others added 30 commits October 1, 2023 20:48

Add updates and "parabolic terms" row to overview.md (trixi-framework…

9e41775

…#1651) * update overview.md * add note on parabolic terms

Fix n_elements in resizing containers (trixi-framework#1655)

7ba1f2e

Use Analysis CB (trixi-framework#1650)

e245dc2

* Use Analysis CB * Apply suggestions from code review --------- Co-authored-by: Hendrik Ranocha <[email protected]>

add comments on sign flips (trixi-framework#1657)

3f4b0f4

add docs of set_libraries! for setting custom HDF5 library (trixi-fra…

bd98469

…mework#1658)

Fix mapping string in StructuredMesh (trixi-framework#1654)

adce486

* Fix mapping string in `StructuredMesh` * `eval` full string to avoid using `Meta.parseall` * Make `mapping_as_string` consistent --------- Co-authored-by: Hendrik Ranocha <[email protected]>

Avoid allocations due to usage of broadcasting operation (trixi-frame…

67ddfbb

…work#1656) * Avoid allocations due to usage of broadcasting operation * Comments & correcting copy-paste error --------- Co-authored-by: Hendrik Ranocha <[email protected]>

Modified non-conservative fluxes to revert src/solvers/dgsem_tree/dg_…

67e379f

…2d.jl back to its original state

remove StartUpDG type piracy (trixi-framework#1665)

1ce4c32

set version to v0.5.45

ae3a053

set development version to v0.5.46-pre

00292d1

Subcell limiting: Added the possibility to use multiple nonconservati…

12c6c1d

…ve terms

Print addition to DOF count (trixi-framework#1669)

10c8d94

Added some comments and improved formatting

7017914

Added expected results for MHD subcell limiting test

5119d97

Restored old Powell source term and created a new function name for t…

ad6177e

…he modified Powell source term. This was needed due to incompatibility on non-conforming meshes.

Fixed bug

9158093

Fixed bug

3dcccc4

Moved new multiple-dispatch structs for to equations.jl

adb930e

Improved allocations

b0e3aad

fix bug in apply_jacobian_parabolic! for P4estMesh (trixi-framewo…

8bc5469

…rk#1668) * fix bug in parabolic jacobian computations * formatting * updating test results and removing duplicate test --------- Co-authored-by: Hendrik Ranocha <[email protected]>

Show percentage of simulation progress (trixi-framework#1659)

1727b07

* show percentage of simulation progress * add notes about AnalysisCallback in docs * generalize for general initial time --------- Co-authored-by: Hendrik Ranocha <[email protected]>

Avoid double computation of local part of non-conservative flux

e0a3fdf

Improved subcell volume integral in y direction and formatting

86884e8

Apply suggestions from code review

0d61cfd

Co-authored-by: Hendrik Ranocha <[email protected]>

Added timers and corrected docstrings

b0caf8e

amrueda added 3 commits October 12, 2023 10:32

Improved formatting

6dae80a

Reduced testing time

0c2e24e

Merge branch 'subcell_limiting_noncons' into subcell_positivity_nonco…

ac792bb

…nservative and fixed some conflicts

amrueda and others added 7 commits October 12, 2023 14:25

Deactivate bar states for subcell positivity MHD test

9c73f4c

The pressure positivity limiter works for MHD

4e6681c

Subcell limiting: Revise order of bounds using a Dict (trixi-framew…

7fd4503

…ork#1649) * Implement order of bounds as Dict * Implement `variable_bounds` directly as Dictionary * Remove unnecessary line of code * Use Symbols instead of Strings

MCL works again FOR CONSERVATIVE SYSTEMS

82c9a2f

Merge branch 'main' into subcell-limiting

14f0093

Merge branch 'subcell-limiting' into subcell_positivity_nonconservative

834b481

Subcell limiting is working with StructuredMesh again

48bd943

amrueda closed this Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add subcell limiting for nonconservative systems to the big subcell-limiting branch #5

Add subcell limiting for nonconservative systems to the big subcell-limiting branch #5

amrueda commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

Add subcell limiting for nonconservative systems to the big subcell-limiting branch #5

Add subcell limiting for nonconservative systems to the big subcell-limiting branch #5

Conversation

amrueda commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

Review checklist

Purpose and scope

Code quality

Documentation

Testing

Performance

Verification