Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi ion collision sources subcell #10

Open
wants to merge 428 commits into
base: multi_ion_collision_sources
Choose a base branch
from
Open

Multi ion collision sources subcell #10

wants to merge 428 commits into from

Conversation

amrueda
Copy link
Owner

@amrueda amrueda commented Nov 23, 2023

No description provided.

bennibolm and others added 30 commits February 12, 2023 14:25
@bennibolm
Merge branch 'ma-bolm-2022-indices' of https://github.com/bennibolm/T…
4a74b85 
…rixi.jl into ma-bolm-2022-indices
@bennibolm
Move reset of alphas
8dddbcd
@bennibolm
Fix alphas for first time step (MCL)
c4ec2fa
@bennibolm
Fix last commit
8ff31e7
@amrueda
Added possibility to use the exact or simplified version of Kuzmin's …
5ac90f9 
…pressure positivity limiter
@bennibolm
Fix variable names
eb2fd59
@bennibolm
Revise calculation of our blending coefficient
d9c9cd7
@bennibolm
Add average calculation of alpha and Kuzmins coefficient
d7dfb22
@amrueda
Added computation of alpha_mean for pressure and entropy limiters, an…
a0ba531 
…d removed the plotting of alpha_rho for other quantities when indicator.DensityAlphaForAll==true
@amrueda
Fixed computation of alpha_mean for pressure and entropy
43e544e
@bennibolm
Revise structure in dg_2d.jl
9393a57
@bennibolm
Add txt output for alpha_entropy; Plus output for alpha_mean and alph…
b1b1c03 
…a_eff for StructuredMesh
@bennibolm
Add simple reflecting Euler wall as outer boundary state for slip wal…
6e9637f 
…l boundary
@bennibolm
Update FCT/IDP and MCL elixirs
09f4dd7
@bennibolm
Add correlation factor beta to MCL positivity limiter
a256191
@bennibolm
Add correlation factor to BoundsCheck
f2f7d64
@bennibolm
Remove interfaces contribution to alpha_mean if not required
90eb54a
@bennibolm
Update elixirs
afa05fc
@bennibolm
Rename alpha_min txt file
ca10fce
@bennibolm
Merge branch 'main' into ma-bolm-2022
edf9af6
@bennibolm
Use name change
111e5d1
@bennibolm
Remove PressurePositivityLimiter
64ede2a
@bennibolm
First step generalizing IDP_positivity!
f41327e
@bennibolm
Fix typos
fd02b38
@bennibolm
Continue generalization
1438f4e
@bennibolm
Merge branch 'main' into ma-bolm-2022
252b540
@bennibolm
merge branch 'main' into ma-bolm-2022
3b0e2f6
@bennibolm
Adjust and fix tests
86be8d4
@bennibolm
Merge branch 'ma-bolm-2022' into subcell-limiting
1066986
@bennibolm
Fix test
3bf2419
amrueda and others added 29 commits October 24, 2023 13:48
@amrueda @bennibolm
Increased maximum allowed allocation bound for subcell limiting simul…
c7c3ca0 
…ation

Co-authored-by: Benjamin Bolm <[email protected]>
@amrueda
Added explanatory comments about different non-conservative fluxes an…
120f9ba 
…d multiple dispatch
@amrueda
Changed variable name noncons_term to nonconservative_term
81d40e2
@amrueda @sloede
Update docstrin of flux_nonconservative_powell_local_symmetric
c7dd7f5 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Renamed function nnoncons as n_nonconservative_terms
7910993
@amrueda
format
3f9f0fe
@amrueda @sloede
Apply suggestions from code review
b6646ad 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda @bennibolm
Non-conservative subcell limiting cache only allocated for non-conser…
0eee721 
…vative equations

Co-authored-by: Benjamin Bolm <[email protected]>
@amrueda
Merge branch 'main' into subcell_limiting_noncons
df12f03
@bennibolm
Merge branch 'main' into subcell-limiting
cb1d5ec
@amrueda
Merge branch 'subcell-limiting' into subcell_positivity_nonconservative
a23b6b1
@amrueda
Merge branch 'subcell_limiting_noncons' into subcell_positivity_nonco…
ee21f0a 
…nservative
@bennibolm
Add allocation tests for StructuredMesh
f3399b6
@amrueda
Merge branch 'subcell-limiting' into subcell_positivity_nonconservative
6f43419
@amrueda
Merge branch 'multi_ion_collision_sources' into multi_ion_collision_s…
011ebd4 
…ources_subcell
@amrueda
Merge branch 'main' into subcell_positivity_nonconservative
3e81bbb
@amrueda
format
113ce70
@amrueda
Updated the reference solution of some subcell limiting tests
400afb7
@amrueda @bennibolm
Add memory allocation test
30b33fd 
Co-authored-by: Benjamin Bolm <[email protected]>
@bennibolm
Merge pull request trixi-framework#116 from amrueda/subcell_positivit…
bd781ec 
…y_nonconservative

Add support for non nonconservative equations to subcell-limiting
@bennibolm
Merge branch 'main' into subcell-limiting
9897ead
@bennibolm
Add unintentionally removed lines
1c845f6
@bennibolm @DanielDoehring
@ranocha @dependabot @sloede @ArseniyKholod
Revise bounds check for MCL (trixi-framework#118)
cb899fe 
* Revise bounds check for MCL

* Rename `idp_bounds_delta` for MCL to `mcl_bounds_delta`

* Remove comment

* Fix allocs (trixi-framework#1695)

* Fix allocs

* remove unnecessary code

* rerun fmt

* format

* Allocation tests dgmulti 2d (trixi-framework#1698)

* HLLE CEE 2D3D NonCartesian Meshes (trixi-framework#1692)

* HLLE CEE 2D3D NonCartesian Meshes

* format

* hlle via hll

* format test

* format test

* format

* do not export hlle

* Correct test vals

* test values CI

* Update src/equations/compressible_euler_2d.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

* Update src/equations/compressible_euler_1d.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

* Update src/equations/compressible_euler_2d.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

* Update src/equations/compressible_euler_3d.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

* Update src/equations/compressible_euler_3d.jl

Co-authored-by: Hendrik Ranocha <[email protected]>

* apply suggestions

* additional sentence

* Fix typo

* typos

* correct test vals

---------

Co-authored-by: Hendrik Ranocha <[email protected]>

* Bump crate-ci/typos from 1.16.15 to 1.16.21 (trixi-framework#1700)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.16.15 to 1.16.21.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.16.15...v1.16.21)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add NumFOCUS + ACTRIX to acknowledgments (trixi-framework#1697)

* Add NumFOCUS + ACTRIX to acknowledgments

* Try to avoid spaces

* Another try to avoid gaps between images

* Hopefully fix image alignment in docs

* Try new logo formats

* Use smaller DUBS logo and add DUBS funding statement

* Add markdown-based table for logos in docs

* Try another table approach

* Hopefully get a layout that finally *works*...

* Arrrrrrgggggghhhhh

* format examples (trixi-framework#1531)

* format examples

* check formatting of examples in CI

* update style guide

* fix weird formatting

* fix formatting of binary operators

* format again

* Update differentiable_programming.jl (trixi-framework#1704)

* Format subcell elixirs

* Add warning for missing bounds check for entropy limiter (MCL)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Daniel Doehring <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: ArseniyKholod <[email protected]>
@amrueda
Merge branch 'subcell-limiting' into multi_ion_collision_sources_subcell
bc8b7fc
@amrueda
format
068b0fe
@amrueda
Merge branch 'multi_ion_collision_sources' into multi_ion_collision_s…
ab7c5c6 
…ources_subcell
@amrueda
Merge branch 'multi_ion_collision_sources' into multi_ion_collision_s…
37eb45d 
…ources_subcell
@amrueda
renamed nnoncons variable for multi-ion MHD 2D
8c49739
@amrueda
Merge branch 'multi_ion_collision_sources' into multi_ion_collision_s…
e04924b 
…ources_subcell
@github-actions GitHub Actions
Copy link

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrueda @bennibolm @ranocha @sloede