Fix plusType for schema that contains only ISL 2.0 version marker #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #305
Also related to #304
Description of changes:
There was incorrect logic for handling appending a new type to a schema in
SchemaImpl_2_0.plusType()
. Theidx == isl.lastIndex
meant that the new type would be inserted before the last value, no matter what it was. So, when the existing schema had only one top-level value (in this case, the$ion_schema_2_0
version marker), the new type would be inserted before the version marker, which is illegal.Now, the logic for adding the type in
plusType()
is as follows:(This is what it was intended to be all along.)
Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.