Add option to provide alternate regex implementation #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
commented
Dec 15, 2023
There was a problem hiding this comment.
The changes in this file are incidental changes. I discovered that the testNameFilter wasn't correctly checking all test cases, and this fixes it.
tgregg
approved these changes
Dec 15, 2023
ion-schema/src/main/kotlin/com/amazon/ionschema/IonSchemaSystemBuilder.kt
Outdated
Show resolved
Hide resolved
…mBuilder.kt Co-authored-by: Tyler Gregg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Adds an option to the
IonSchemaSystemBuilderthat allows users to provide an alternate regex implementation in order to e.g. get better performance characteristics.Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.