Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds writers for remaining constraints #293

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

  • Adds writers for AnnotationsV2, Contains, Element, FieldNames, Ieee754Float, and Regex constraints.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...hema/writer/internal/constraints/ContainsWriter.kt 0.00% <0.00%> (ø)
.../writer/internal/constraints/Ieee754FloatWriter.kt 0.00% <0.00%> (ø)
...iter/internal/constraints/TimestampOffsetWriter.kt 0.00% <0.00%> (ø)
...chema/writer/internal/constraints/ElementWriter.kt 40.00% <40.00%> (ø)
...nschema/writer/internal/constraints/RegexWriter.kt 0.00% <0.00%> (ø)
...ma/writer/internal/constraints/FieldNamesWriter.kt 0.00% <0.00%> (ø)
...writer/internal/constraints/AnnotationsV2Writer.kt 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@popematt popematt merged commit fee907d into amazon-ion:master Oct 20, 2023
3 of 5 checks passed
@popematt popematt deleted the writer-part-5 branch June 13, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants