Ensures that macro arguments are present in the binary reader's buffer before attempting to materialize them. #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r before attempting to materialize them.
jobarr-amzn
approved these changes
Oct 30, 2024
Comment on lines
+60
to
+65
| // Note: the following line ensures the entire container is buffered. This improves performance when reading the | ||
| // container's elements because there is less work to do per element. However, very large containers would | ||
| // increase memory usage. The current implementation already assumes this risk by eagerly materializing | ||
| // macro invocation arguments. However, if that is changed, then removing the following line should also be | ||
| // considered. | ||
| prepareValue() |
There was a problem hiding this comment.
Thanks for the context :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #984
Description of changes:
The top-level binary reader implementation calls
fillValue()before materializing scalar values. However, theReaderAdapterContinuableoperates over the core-level reader. Therefore, it must explicitly fill the scalar values it materializes. This adapter is used by both theEExpressionArgsReaderand theMacroCompiler. The fix allows the reader to read from data that is not entirely present in the buffer up-front.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.