Fixes a bug that prevented seeking to a span created from a different reader in a stream with a large number of symbols. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reader in a stream with a large number of symbols.
linlin-s
approved these changes
May 8, 2024
rmarrowstone
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Before this fix, the code assumed the following, which was included in a comment:
This was valid as long as the same reader that produced a span would always be hoisted to that span. However, the
SeekableReaderfacet allows different readers to share spans as long as they are reading the same stream. When this is the case, the constraint asserted by the comment no longer holds: the reader that produced the span may have progressed far enough in the stream to encounter more symbols than would fit in the other reader'ssymbolsarray. In that case, before this fix, anArrayIndexOutOfBoundsExceptionwould be thrown. After this fix, the reader that is hoisted to the span will grow itssymbolsarray if necessary so that it can fit the symbols that are in scope at the span's destination location.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.