Fixes JSON down converter decimal spec issue. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Nov 5, 2021
Co-authored-by: Matthew Pope <[email protected]>
popematt
approved these changes
Nov 5, 2021
tgregg
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
This will work, but before merging I recommend looking into one alternative solution, which is to never write a decimal point immediately before d or e, even in text Ion. I don't believe it's ever required, and is therefore just a waste of a character. It looks like this decimal point is added in BigDecimal.ToString here.
|
Opened an issue #136 for Tyler's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ion allows
2.d-1indicating0.2while JSON doesn't. When IonDoNet JSON downconverter converts2.d-1to JSON decimal, it returns2.e-1which is an invalid JSON decimal since exponentecan't follow.directly. Refer to JSON spec for more details.So IonDotNet JSON down converter should return a valid JSON decimal (e.g.
2e-1).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.