-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum Neuron #110
Quantum Neuron #110
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Running:
will let the linters fix the formatting issues. |
Would it be possible for you to expand this example to have an actual network use the quantum Neuron? |
src/braket/experimental/algorithms/quantum_neuron/quantum_neuron.py
Outdated
Show resolved
Hide resolved
Returns: | ||
List[float]: List of random numbers. | ||
""" | ||
random.seed(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose for a fixed seed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it reproducible.
Is it not very common to fix seed?
src/braket/experimental/algorithms/quantum_neuron/quantum_neuron.py
Outdated
Show resolved
Hide resolved
src/braket/experimental/algorithms/quantum_neuron/quantum_neuron.py
Outdated
Show resolved
Hide resolved
@christianbmadsen |
Codecov ReportPatch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
update mock files for quantum neuron
+1 on Christian's request - we'd like to see an actual end-to-end use case here. It's fine if the usage is limited to simulators. Thanks! |
Hello YutoTakaki, This PR has had little activity; I will close it for now. You are welcome to come back and work on it and reopen it any time. You can also consider developing this work further in a seperate repo of yours and highlighting it on in Braket Algorithm library "Community repos" section, which we recently added. I hope this helps. |
Issue #, if available:
Description of changes:
added an example about quantum neuron.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.