Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to manifest v3 and apply some changes for compatibilization with the new version #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

warguns
Copy link

@warguns warguns commented Jan 12, 2023

BEWARE Please, test it first before merge!

Unfortunately, I don't have Netflix (and chill) account and I was not able to test it during a movie.

Also, there's some minor changes:

  • Apply strict equals on the comparisons and some formatting.
  • Remove jquery from the background.js.
  • Use a different approach for the light/dark mode detection due the new manifest restrictions (like we cannot check the window object on the background).

For now, I just only verified that the popup interactions were working right and the icon color is changed when you're opening some tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant