seq: Avoid strlcat()

strlcat() isn't available in every system, so better to avoid it. Rewrite the code without strlcat(). Fixes: 6167b8c ("seq: Add API helper functions for creating UMP Endpoint and Blocks") Link: https://lore.kernel.org/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
alsa-project · Jul 31, 2024 · d969439 · d969439
1 parent f090a93
commit d969439
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/seq/seqmid.c b/src/seq/seqmid.c
@@ -635,6 +635,7 @@ static void update_group_ports(snd_seq_t *seq, snd_ump_endpoint_info_t *ep)
 		char blknames[64];
 		char name[64];
 		unsigned int caps = 0;
+		int len;
 
 		blknames[0] = 0;
 		for (b = 0; b < ep->num_blocks; b++) {
@@ -668,14 +669,13 @@ static void update_group_ports(snd_seq_t *seq, snd_ump_endpoint_info_t *ep)
 
 			if (!*bp->name)
 				continue;
-			if (*blknames) {
-				strlcat(blknames, ", ", sizeof(blknames));
-				strlcat(blknames, (const char *)bp->name,
-					sizeof(blknames));
-			} else {
+			len = strlen(blknames);
+			if (len)
+				snprintf(blknames + len, sizeof(blknames) - len,
+					 ", %s", bp->name);
+			else
 				snd_strlcpy(blknames, (const char *)bp->name,
 					    sizeof(blknames));
-			}
 		}
 
 		if (!*blknames)