Add hex value option to color methods #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hex value option to foreground color and background color methods. Changed parameter to accept either 3 rgb values or 1 hex value. Python doesn't have a great way to have different number of parameters for a single function. Followed stack overflow thread: https://stackoverflow.com/questions/5079609/methods-with-the-same-name-in-one-class-in-python/74745600#74745600
|
Thanks! Does this impact current users who might call the function like this?
Or maybe even worse |
|
This would impact current users calling the function with parameters named unfortunately. I can look into a way to maintain this functionality in Python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hex value option to foreground color and background color methods.
Changed parameter to accept either 3 rgb values or 1 hex value.
Added new test cases and successfully ran tests locally.
Python doesn't have a great way to have different number of parameters for a single function. Followed stack overflow thread