Fix release version in footer #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgaDufrat
approved these changes
Sep 25, 2023
AgaDufrat
reviewed
Sep 25, 2023
deborahchua
force-pushed
the
fix-footer-version
branch
from
9019316
to
dc84e5c
Compare
I cannot take the credit - this was @robinjam 's suggestion! 🥇 |
This has been broken since we moved to EKS and the SHA is no longer provided. We can use the [SENTRY_RELEASE](https://github.com/alphagov/govuk-helm-charts/blob/077117e7f40c096a958f9e0b853a2bd76cf43f26/charts/generic-govuk-app/templates/deployment.yaml#L92C1-L92C1) environment variable which is defined for every app and takes its value from the container image's tag. If for whatever reason the image tag is not defined it will display `null`, which should make it clearer (instead of displaying `development`) that this data is not being pulled in successfully.
deborahchua
force-pushed
the
fix-footer-version
branch
from
dc84e5c
to
88f1494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been broken since we moved to EKS and the SHA is no longer provided.
We can use the SENTRY_RELEASE environment variable which is defined for every app and takes its value from the container image's tag.
If for whatever reason the image tag is not defined it will display
null, which should make it clearer (instead of displayingdevelopment) that this data is not being pulled in successfully.Before:
After (tested in Integration):
Trello card: https://trello.com/c/uoKDUcbV/3182-fix-broken-version-footer-in-publishing-apps-2
Follow these steps if you are doing a Rails upgrade.