Don't fall back to fixture data in production #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EmergencyContactDetails` class relies on a `EMERGENCY_CONTACT_DETAILS` ENV variable to define sensitive information such as phone numbers and email addresses, which we then display in the Support app. If the ENV variable is missing, then it falls back to the nonsense data in `config/emergency_contact_details.json`, potentially displaying incorrect information to publishers. It would be better for the application to crash. The fallback behaviour has instead been moved to `config/environments`, in `development.rb` and `test.rb` only. This is so that the app can be started up without having to define the ENV var (`development.rb`) and so that all of the unrelated tests continue to pass (`test.rb`).
robinjam
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EmergencyContactDetailsclass relies on aEMERGENCY_CONTACT_DETAILSENV variable to define sensitive information such as phone numbers and email addresses, which we then display in the Support app.If the ENV variable is missing, then it falls back to the nonsense data in
config/emergency_contact_details.json, potentially displaying incorrect information to publishers. It would be better for the application to crash.The fallback behaviour has instead been moved to
config/environments, indevelopment.rbandtest.rbonly. This is so that the app can be started up without having to define the ENV var (development.rb) and so that all of the unrelated tests continue to pass (test.rb).Follow these steps if you are doing a Rails upgrade.