Search with autocomplete: Set minimum query length #4382
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops the component from wasting requests trying to fetch suggestions when our backend won't provide any for query lengths < 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This stops the
search_with_autocompletecomponent from wasting requests trying to fetch suggestions when our backend won't provide any for query lengths < 3.Why
Fewer pointless requests is better!
Note that I've not bothered making this configurable - it's unlikely for the time being that this component will be used with a different source/backend, so there isn't much point in adding a configuration option. I've also not added a changelog option as that felt over the top 😄