Rename gem-print-link and gem-print-links-within #4375

AshGDS · 2024-11-07T15:31:05Z

What / Why

The component wrapper helper has some validation that restrict what classes can be added to components.
This validation doesn't like gem-print-link and gem-print-links-within as they don't conform to the validation.
Therefore, I discussed with Andy and we've renamed them to use gem-c- so that they pass the validation.
This will unblock me adding the component wrapper to more components.

None.

matthillco

Looks good to me.

The component wrapper helper doesn't like this class, so we've agreed to rename it.

AshGDS self-assigned this Nov 7, 2024

govuk-ci temporarily deployed to components-gem-pr-4375 November 7, 2024 15:31 Inactive

AshGDS force-pushed the rename-print-link-classes branch from 347f6bc to 02ba082 Compare November 7, 2024 15:41

govuk-ci temporarily deployed to components-gem-pr-4375 November 7, 2024 15:42 Inactive

AshGDS marked this pull request as ready for review November 7, 2024 15:50

AshGDS force-pushed the rename-print-link-classes branch from 02ba082 to a8bcb78 Compare November 7, 2024 15:51

govuk-ci temporarily deployed to components-gem-pr-4375 November 7, 2024 15:52 Inactive

AshGDS requested a review from matthillco November 7, 2024 15:57

matthillco approved these changes Nov 11, 2024

View reviewed changes

Rename gem-print-link and gem-print-links-within

774ade1

The component wrapper helper doesn't like this class, so we've agreed to rename it.

AshGDS force-pushed the rename-print-link-classes branch from a8bcb78 to 774ade1 Compare November 11, 2024 13:51

govuk-ci temporarily deployed to components-gem-pr-4375 November 11, 2024 13:51 Inactive

AshGDS merged commit 92a6f81 into main Nov 11, 2024
12 checks passed

AshGDS deleted the rename-print-link-classes branch November 11, 2024 13:54