Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Commit

Permalink
fix suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
b-m-alm committed Nov 15, 2022
1 parent 6fb75fa commit 29fc863
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
2 changes: 1 addition & 1 deletion alma_client/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def data(self):

def to_httpx(self):
self.context.credentials.configure(self)
headers = dict(self.headers)
headers = self.headers.copy()
headers["Content-Type"] = "application/json"
req = httpx.Request(
self.method,
Expand Down
18 changes: 4 additions & 14 deletions tests/test_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,10 @@ def setUp(self) -> None:
self.credentials = client.context.credentials
self.request = Request(client.context, "https://url.com")

def assert_method_calls_configure(self, method):
def test_credentials_configure_is_called_on_request_build(self):
with mock.patch("alma_client.credentials.ApiKeyCredentials.configure") as mocked_configure:
getattr(self.request, method)()
self.request.get()
mocked_configure.assert_not_called()
# only upon building the httpx Req are the credentials configured
_ = self.request.to_httpx()
mocked_configure.assert_called_once_with(self.request)

def test_credentials_configure_is_called_on_get(self):
self.assert_method_calls_configure("get")

def test_credentials_configure_is_called_on_post(self):
self.assert_method_calls_configure("post")

def test_credentials_configure_is_called_on_put(self):
self.assert_method_calls_configure("put")

def test_credentials_configure_is_called_on_delete(self):
self.assert_method_calls_configure("delete")

0 comments on commit 29fc863

Please sign in to comment.