-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create endpoint and formatter for gather cms data #142
base: develop
Are you sure you want to change the base?
Create endpoint and formatter for gather cms data #142
Conversation
|
||
public function setUp(): void | ||
{ | ||
$this->merchantEndpoint = Mockery::mock(Merchants::class)->makePartial(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to remove Mockery and use native mock ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we want to test an endpoint, I'm note sure we can do it without a makePartial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments has been see in mob review :)
Quality Gate failedFailed conditions |
Reason for change
Linear task
We need to implement new endpoint to save an url for gathering CMS data.
Code changes
How to test
As a reviewer, you are encouraged to test the PR locally.
You can run unit tests
Checklist for authors and reviewers
Non applicable