Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint alloy-json-abi #757

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix lint alloy-json-abi #757

merged 1 commit into from
Oct 4, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 4, 2024

Motivation

Failing CI due to lint warning clippy::needless_lifetimes.

Solution

Fixes lint warnings for alloy-json-abi.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane requested a review from prestwich as a code owner October 4, 2024 12:07
mattsse
mattsse approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lint fixes should be done in one pr so we can actual check all lints are fixed

@mattsse mattsse merged commit 1aa26cc into main Oct 4, 2024
28 of 29 checks passed
@mattsse mattsse deleted the emhane/fix-lint-json-abi branch October 4, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse