Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bearer token credentials request #149

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

yndu13
Copy link
Contributor

@yndu13 yndu13 commented Jun 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 53.91705% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 44.25%. Comparing base (2fc1b2d) to head (cb9226c).

Files Patch % Lines
python/alibabacloud_tea_openapi/client.py 41.48% 55 Missing ⚠️
golang/client/client.go 56.00% 24 Missing and 9 partials ⚠️
ts/src/client.ts 74.46% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   43.23%   44.25%   +1.02%     
==========================================
  Files           5        5              
  Lines        2984     3071      +87     
  Branches      104      107       +3     
==========================================
+ Hits         1290     1359      +69     
- Misses       1549     1563      +14     
- Partials      145      149       +4     
Flag Coverage Δ
golang 48.71% <56.00%> (+0.73%) ⬆️
python 35.56% <42.10%> (+0.63%) ⬆️
typescript 56.31% <74.46%> (+2.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yndu13 yndu13 force-pushed the support-bearer-token branch 5 times, most recently from dbffe95 to cb9226c Compare June 3, 2024 03:24
main.tea Outdated
var bearerToken = getBearerToken();
__request.query.BearerToken = bearerToken;
__request.query.SignatureType = 'BEARERTOKEN';
__request.headers.authorization = `bearer ${bearerToken}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bearer 首字母大写不?

__request.query.SignatureType = 'BEARERTOKEN';
__request.headers.authorization = `bearer ${bearerToken}`;
} else {
var accessKeyId = getAccessKeyId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不换成 getCredentialsModel 么

@yndu13 yndu13 changed the title feat: support bearer token credentials request [WIP等网关改造]feat: support bearer token credentials request Jun 4, 2024
@yndu13 yndu13 changed the title [WIP等网关改造]feat: support bearer token credentials request feat: support bearer token credentials request Jun 21, 2024
@JacksonTian JacksonTian merged commit cb7a54a into master Jun 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants