-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New alr printenv --last-build
#1444
New alr printenv --last-build
#1444
Conversation
src/alr/alr-commands-printenv.adb
Outdated
Define_Switch (Config, | ||
Cmd.Last_Build'Access, | ||
"", "--last-build", | ||
"Use last build profiles instead of manifest profiles"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the use for this switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new shared builds the actual paths change depending on the build profile.
Now, alr printenv
relies on the info in the manifests, always printing the same info. With this, one could do
alr build --profiles=*=validation
alr printenv --last-build
and get the paths for validation builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider this to be the default behavior. We already save the last build profile somewhere, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they're saved after every build. That's what's being used to set the profiles here indeed.
We could make alr printenv
understand the --profiles
switch too, in case one wants to get a particular environment without forcing a build in advance.
This may be useful when no direct editing of manifests is convenient, as otherwise `printenv` will always use the manifest's configuration.
0552e9d
to
4f0df6b
Compare
f64ba88
to
393d4ce
Compare
Modified to make this the default behavior |
This may be useful when no direct editing of manifests is convenient, as otherwise
printenv
will always use the manifest's configuration.