Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New alr printenv --last-build #1444

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Sep 4, 2023

This may be useful when no direct editing of manifests is convenient, as otherwise printenv will always use the manifest's configuration.

@mosteo mosteo marked this pull request as ready for review September 4, 2023 19:52
Define_Switch (Config,
Cmd.Last_Build'Access,
"", "--last-build",
"Use last build profiles instead of manifest profiles");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the use for this switch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new shared builds the actual paths change depending on the build profile.

Now, alr printenv relies on the info in the manifests, always printing the same info. With this, one could do

alr build --profiles=*=validation
alr printenv --last-build

and get the paths for validation builds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider this to be the default behavior. We already save the last build profile somewhere, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're saved after every build. That's what's being used to set the profiles here indeed.

We could make alr printenv understand the --profiles switch too, in case one wants to get a particular environment without forcing a build in advance.

This may be useful when no direct editing of manifests is convenient, as
otherwise `printenv` will always use the manifest's configuration.
@mosteo mosteo force-pushed the feat/printenv-saved-profile branch 2 times, most recently from 0552e9d to 4f0df6b Compare October 2, 2023 20:14
@mosteo mosteo force-pushed the feat/printenv-saved-profile branch from f64ba88 to 393d4ce Compare October 3, 2023 05:27
@mosteo
Copy link
Member Author

mosteo commented Oct 3, 2023

Modified to make this the default behavior

@mosteo mosteo merged commit ffc5659 into alire-project:master Oct 3, 2023
12 checks passed
@mosteo mosteo deleted the feat/printenv-saved-profile branch October 3, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants