Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include compiler version in build hash #1430

Closed
wants to merge 3 commits into from

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Aug 25, 2023

No description provided.

@mosteo mosteo marked this pull request as ready for review August 25, 2023 10:34
@@ -147,6 +147,15 @@ package body Alire.Builds.Hashes is
-- Configuration variables
-- TBD

-- Compiler version. Changing compiler will result in incompatible
-- ALI files and produce rebuilds, so it must be part of the hash.
-- Incidentally, this serves to separate by cross-target too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler is able to detect incompatible build artifact, but it's probably better to avoid the error message.

Also note that this will not handle all case for cross-target since a given cross compiler can support multiple instruction sets. For instance arm-elf can do Arm Cortex-M0, Cortex-M7, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that this will not handle all case for cross-target since a given cross compiler can support multiple instruction sets. For instance arm-elf can do Arm Cortex-M0, Cortex-M7, etc.

Right; for those I understood that we're not going to do anything directly, but that the project file will separate the objects into folders?

I guess at some point we can use libgpr to extract the necessary info from the project file?

@mosteo mosteo deleted the branch feat/hash-externals September 4, 2023 08:23
@mosteo mosteo closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants