Debug when folder deletion fails #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
requested changes
Aug 9, 2023
src/alire/alire-directories.adb
Outdated
| Output : Vector; | ||
| Code : constant Integer := | ||
| OS_Lib.Subprocess.Unchecked_Spawn_And_Capture | ||
| ("ls", To_Vector ("-alRF"), |
There was a problem hiding this comment.
I don't think it's good to rely on and external ls command here. On Windows it might not be available.
|
I've added an alternative for Windows. Nonetheless, this is kind of a brute attempt to diagnose exactly the failures happening here... Other ideas welcome :S |
|
I know what the root cause is now and can reproduce locally, working on the fix. |
|
The CI error in this one will go away after #1427 |
Fabien-Chouteau
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra output when a file/folder deletion fails, to try and debug occurrences like #1417.