Pass additional start arguments with environment variable

In case you'd like to configure the start arguments of `valkey-server` with environment variable, you can pass them with `VALKEY_EXTRA_FLAGS` without having to overwrite the CMD: ```console $ docker run --env VALKEY_EXTRA_FLAGS='--save 60 1 --loglevel warning' valkey/valkey ``` resolves valkey-io#18 Signed-off-by: Ali Ismayilov <[email protected]>
aliismayilov · Sep 28, 2024 · 49e7a04 · 49e7a04
1 parent 7ab75b4
commit 49e7a04
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 9 deletions.
diff --git a/7.2/alpine/docker-entrypoint.sh b/7.2/alpine/docker-entrypoint.sh
diff --git a/7.2/debian/docker-entrypoint.sh b/7.2/debian/docker-entrypoint.sh
diff --git a/8.0/alpine/docker-entrypoint.sh b/8.0/alpine/docker-entrypoint.sh
diff --git a/8.0/debian/docker-entrypoint.sh b/8.0/debian/docker-entrypoint.sh
diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh
@@ -19,4 +19,4 @@ if [ "$um" = '0022' ]; then
 	umask 0077
 fi
 
-exec "$@"
+exec "$@" $VALKEY_EXTRA_FLAGS
diff --git a/dockerhub-description.md b/dockerhub-description.md
@@ -1,9 +1,9 @@
 # Quick reference
 
--	**Maintained by**:  
+-	**Maintained by**:
 	[the Valkey Community](https://github.com/valkey-io/valkey-container)
 
--	**Where to get help**:  
+-	**Where to get help**:
 	Please open an Issue stating your question on [the Valkey Community](https://github.com/valkey-io/valkey-container/issues).
 
 # Supported tags and respective `Dockerfile` links
@@ -49,6 +49,15 @@ There are several different persistence strategies to choose from. This one will
 $ docker run -it --network some-network --rm valkey/valkey valkey-cli -h some-valkey
 ```
 
+## Pass additional start arguments with environment variable
+
+In case you'd like to configure the start arguments of `valkey-server`
+with environment variable, you can pass them with `VALKEY_EXTRA_FLAGS`
+without having to overwrite the CMD:
+```console
+$ docker run --env VALKEY_EXTRA_FLAGS='--save 60 1 --loglevel warning' valkey/valkey
+```
+
 ## Additionally, If you want to use your own valkey.conf ...
 
 You can create your own Dockerfile that adds a valkey.conf from the context into /data/, like so.

diff --git a/unstable/alpine/docker-entrypoint.sh b/unstable/alpine/docker-entrypoint.sh
diff --git a/unstable/debian/docker-entrypoint.sh b/unstable/debian/docker-entrypoint.sh