Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick self monitor: merge 1.8.x #1773

Merged
merged 19 commits into from
Oct 11, 2024
Merged

Conversation

@Takuka0311 Takuka0311 changed the title pick self monitor Pick self monitor: merge 1.8.x Sep 23, 2024
@Takuka0311
Copy link
Collaborator Author

这个PR现在有一个问题,就是2.1版本的e2e测试为老版本,依赖老的go自监控链路。但是我这边改造完后,老的go自监控链路就作废了,e2e就会挂掉,这个问题暂时无解。

这边有三个方案:
1、改动代码,适配老的e2e测试要求(感觉没有必要,老的e2e已经是被淘汰的)
2、合入新的e2e测试到2.1
3、把老的e2e测试中依赖旧的go自监控数据的部分删掉

最终选择应该是方案三,开发中

@Takuka0311
Copy link
Collaborator Author

为了跑通e2e,删除了e2e中关于自监控数据的监测部分、删除了旧的自监控内置pipeline statisticsConfig(已经没有用了)

@Takuka0311 Takuka0311 merged commit 60b3c44 into alibaba:2.1 Oct 11, 2024
15 checks passed
@henryzhx8 henryzhx8 added the feature request New feature request label Oct 22, 2024
@henryzhx8 henryzhx8 added this to the v2.1 milestone Oct 22, 2024
@Takuka0311 Takuka0311 deleted the add-self-monitor branch October 30, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants