Feature/metadata #1768
Open
Feature/metadata #1768
+1,328
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NameHaibinZhang
force-pushed
the
feature/metadata
branch
from
c8cd6f1
to
ce5fa17
Compare
linrunqi08
reviewed
Sep 24, 2024
linrunqi08
approved these changes
Sep 26, 2024
messixukejia
requested changes
Sep 27, 2024
| @@ -0,0 +1,245 @@ | |||
| /* | |||
| * LRUCache11 - a templated C++11 based LRU cache class that allows | |||
There was a problem hiding this comment.
| std::cerr << "Failed to parse JSON: " << errors << std::endl; | ||
| return; | ||
| } | ||
|
|
| // Copyright 2022 iLogtail Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. |
| for (const auto& key : json["labels"].getMemberNames()) { | ||
| if (json["labels"].isMember(key)) { | ||
| info.labels[key] = json["labels"][key].asString(); | ||
| if (key == "armsAppId") { |
There was a problem hiding this comment.
不能直接有arms的变量，具体处理策略core/ebpf/handler/ObserveHandler.cpp
| std::chrono::system_clock::time_point th2 = std::chrono::system_clock::from_time_t(now); | ||
| std::chrono::duration<double> diff = th2 - th1; | ||
| double minutes_diff = diff.count() / 60.0; | ||
| if (minutes_diff > 10) { |
| FromContainerJson(root, data); | ||
| for (const auto& pair : data->containers) { | ||
| if (infoType == containerInfoType::ContainerIdInfo) { | ||
| containerCache.insert(pair.first, std::make_shared<k8sContainerInfo>(pair.second)); |
| return; | ||
| } | ||
| FromContainerJson(root, data); | ||
| for (const auto& pair : data->containers) { |
There was a problem hiding this comment.
containers没有老化机制？只增不删？
|
|
||
| if (reader->parse(res.mBody.c_str(), res.mBody.c_str() + res.mBody.size(), &root, &errors)) { | ||
| std::shared_ptr<ContainerData> data = std::make_shared<ContainerData>(); | ||
| FromContainerJson(root, data); |
There was a problem hiding this comment.
FromContainerJson 外部输入都是不可靠的
| } | ||
| Json::StreamWriterBuilder writer; | ||
| std::string output = Json::writeString(writer, jsonObj); | ||
| SendRequestToOperator(mServiceHost, output, containerInfoType::ContainerIdInfo); |
There was a problem hiding this comment.
SendRequestToOperator 失败机制也不统一
| } | ||
| request = std::make_unique<HttpRequest>("GET", false, mServiceHost, mServicePort, path, "", map<std::string, std::string>(), output, 30, 3); | ||
| bool success = SendHttpRequest(std::move(request), res); | ||
| if (res.mStatusCode != 200) { |
There was a problem hiding this comment.
success跟res.mStatusCode的顺序是什么
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add k8s metadata