add K8s meta self metrics #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/helper/self_metrics_constants.go
Outdated
| * service_kubernetes_meta | ||
| **********************************************************/ | ||
| const ( | ||
| MetricPluginCollectEntityTotal = "plugin_collect_entity_total" |
There was a problem hiding this comment.
这个命名不是太对，输入输出不需要再有特殊的标识，参考C++部分
There was a problem hiding this comment.
这里讨论下来，通用的输入输出没有办法表达两种数据类型的含义，所以这里相当于属于meta的特殊指标。
linrunqi08
reviewed
Oct 10, 2024
| @@ -84,7 +95,16 @@ func (m *MetaManager) Init(configPath string) (err error) { | |||
| return err | |||
| } | |||
| m.clientset = clientset | |||
| m.metricContext = &helper.LocalContext{} | |||
|
|
|||
| m.metricRecord = pipeline.MetricsRecord{} | |||
There was a problem hiding this comment.
这个是runner级别的，在导出的时候，会填入cluster id，runner name和project。
linrunqi08
requested changes
Oct 11, 2024
| @@ -84,7 +95,16 @@ func (m *MetaManager) Init(configPath string) (err error) { | |||
| return err | |||
| } | |||
| m.clientset = clientset | |||
| m.metricContext = &helper.LocalContext{} | |||
|
|
|||
| m.metricRecord = pipeline.MetricsRecord{} | |||
linrunqi08
approved these changes
Oct 12, 2024
messixukejia
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 新增可观测指标：
2. 调整部分entity和link字段
3. 支持没有采集配置时，仍然可以启动HTTP Server（ebpf场景）