Reconstruct appconfig to support InstanceConfig. #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
requested changes
Sep 24, 2024
core/runner/FlusherRunner.cpp
Outdated
| @@ -43,9 +45,61 @@ bool FlusherRunner::Init() { | |||
| srand(time(nullptr)); | |||
| mThreadRes = async(launch::async, &FlusherRunner::Run, this); | |||
| mLastCheckSendClientTime = time(nullptr); | |||
| LoadModuleConfig(true); | |||
| AppConfig::GetInstance()->RegisterCallback( | |||
There was a problem hiding this comment.
1、参数热加载变更，是否有统一的日志打印？最好有统一格式，由框架进行打印，便于查找日志。
2、打印的时机，最好是生效的时间，而不是读取的时间。因为读取后不一定格式正确。
messixukejia
approved these changes
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 15, 2024
yyuuttaaoo
reviewed
Oct 16, 2024
yyuuttaaoo
reviewed
Oct 16, 2024
yyuuttaaoo
reviewed
Oct 16, 2024
yyuuttaaoo
reviewed
Oct 16, 2024
yyuuttaaoo
approved these changes
Oct 16, 2024
yyuuttaaoo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.