-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: check pipeline queue before scrape, try again after 1 second if is not valid to push #1757
Open
catdogpandas
wants to merge
9
commits into
alibaba:main
Choose a base branch
from
catdogpandas:update/prom-use-ack-queue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−40
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e59989
chore: use IsValidToPush
catdogpandas dc936ea
feat: check pipeline queue before scrape, try after 1 second if is no…
catdogpandas 681409b
feat: update PromFuture to support pre check
catdogpandas 826acbb
Merge branch 'main' into update/prom-use-ack-queue
catdogpandas 1864bfe
chore: update code style
catdogpandas e438aa8
chore: update
catdogpandas 0db69c3
fix: dead lock when use IsValid interface to DelayExecTime
catdogpandas 0ff0812
chore: update code style
catdogpandas 4f970e5
chore: do not start timer and curl in uint test case
catdogpandas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,38 @@ | ||
#include "prometheus/async/PromFuture.h" | ||
|
||
#include "common/Lock.h" | ||
#include "common/http/HttpResponse.h" | ||
|
||
namespace logtail { | ||
|
||
void PromFuture::Process(const HttpResponse& response, uint64_t timestampMilliSec) { | ||
template <typename... Args> | ||
bool PromFuture<Args...>::Process(Args... args) { | ||
WriteLock lock(mStateRWLock); | ||
if (mState == PromFutureState::New) { | ||
for (auto& callback : mDoneCallbacks) { | ||
callback(response, timestampMilliSec); | ||
if (!callback(std::forward<Args>(args)...)) { | ||
mState = PromFutureState::Done; | ||
return false; | ||
} | ||
} | ||
mState = PromFutureState::Done; | ||
} else { | ||
return; | ||
} | ||
|
||
return true; | ||
} | ||
|
||
void PromFuture::AddDoneCallback(std::function<void(const HttpResponse&, uint64_t timestampMilliSec)>&& callback) { | ||
template <typename... Args> | ||
void PromFuture<Args...>::AddDoneCallback(CallbackSignature&& callback) { | ||
mDoneCallbacks.emplace_back(std::move(callback)); | ||
} | ||
|
||
void PromFuture::Cancel() { | ||
template <typename... Args> | ||
void PromFuture<Args...>::Cancel() { | ||
WriteLock lock(mStateRWLock); | ||
mState = PromFutureState::Done; | ||
} | ||
|
||
template class PromFuture<const HttpResponse&, uint64_t>; | ||
template class PromFuture<>; | ||
|
||
} // namespace logtail |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个加一秒是固定的吗?不需要可配置?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该不需要可配置,这部分执行的条件是处理或发送出现背压,延迟调度1s、5s效果都是一样的,进行毫秒级别的延迟可能队列仍旧是满的,所以就固定成1s了。