Add support for GetAddress UK Postcode Geocoding and Lookups #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for GetAddress (getaddress.io) postcode geocoding and lookups.
This commit removes the sanitize method from query (as it's never a hash) and instead ensures the query string doesn't contain whitespace.
This commit adds support for GetAddress (getaddress.io) postcode geocoding and lookups.
Resolve deprecation warning
* add trimble maps backend https://developer.trimblemaps.com/restful-apis/location/single-search/single-search-api/ * add tests & fix a few bugs * add url escaping * add Trimble Maps to API guide * don't depend on activesupport * raise an error if api key is invalid * rename to PC Miler The company is Trimble. The mapping product is Trimble Maps. The geolocation service is PC Miler.
…eisner#1616) Document caching limitations in API guide
* adds metadata add metadata option to single search for trimble maps api call * modify fixtures * Revert "modify fixtures" This reverts commit 67334e3. * copy metadata over to each location so data object would include that adds test for that * update fixtures * add bang to add_metadata_to_locations method name
* Remove double encoding * Fix existing test
mark-young-atg
force-pushed
the
get_address_1.8.2-sma1970
branch
from
f7608ab
to
803a3df
Compare
|
Thanks for this. From what I can tell it looks pretty good, but could you please rebase to current master so I can run tests and review properly? Thanks! |
|
Apologies @alexreisner. I'm not sure how this PR turned into such a fresh hot mess so quickly. I've given up with trying to maintain any sort of history of the original commits for this work. Instead I've opened a fresh PR which is straight forward and clean. I'll close this one. Thank you very much in advance for looking at this new functionality. I stand ready to address any concerns you may raise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for GetAddressUk lookups