Emit errors only when listeners are present

alexpenev-s · Nov 23, 2016 · 8105450 · 8105450
1 parent 68b275e
commit 8105450
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/lib/protocol/Connection.js b/lib/protocol/Connection.js
@@ -223,8 +223,10 @@ Connection.prototype._addListeners = function _addListeners(socket) {
     if (cb) {
       self._state.receive = null; // a callback should be called only once
       cb(err);
-    } else {
+    } else if (self.listenerCount('error')) {
       self.emit('error', err);
+    } else {
+      debug('onerror', err);
     }
   }
   socket.on('error', onerror);

diff --git a/lib/protocol/ConnectionManager.js b/lib/protocol/ConnectionManager.js
@@ -78,11 +78,6 @@ ConnectionManager.prototype._openConnectionMultiDbCase = function _openConnectio
     }
   }
 
-  function onError(err) {
-    cb(err);
-  }
-  conn.on('error', onError);
-
   function handleError(err) {
     conn.close();
     cb(err);
@@ -99,7 +94,6 @@ ConnectionManager.prototype._openConnectionMultiDbCase = function _openConnectio
       }
 
       if (info.isConnected) {
-        conn.removeListener('error', onError);
         cb(null);
       } else {
         conn._closeSilently();

diff --git a/test/hdb.Client.js b/test/hdb.Client.js
@@ -513,12 +513,12 @@ describe('hdb', function () {
           databaseName: 'DB0'
         });
 
-        client._connection.fetchDbConnectInfo = function () {
-          client._connection.emit('error', new Error('Network error emitted'));
+        client._connection.fetchDbConnectInfo = function (options, cb) {
+          cb(new Error('Network error'));
         };
 
         client.connect(function (err) {
-          err.message.should.equal('Could not connect to any host: [ localhost:30013 - Network error emitted ]');
+          err.message.should.equal('Could not connect to any host: [ localhost:30013 - Network error ]');
           done();
         });
       });