Refactor PhonemeTable as to make it maintainable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the pmd workflow is broken... interesting... edit: looks like pmd hasn't been updated here since 2022. whoops.. |
update pmd in open pull request
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
PMD found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…dcramer/Susquehanna into 19-refactor-phonemetablerefresh
|
Documentation is lacking; however there is an open issue specifically for it. As such, documentation will be added there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19. Refactored PhonemeTable, so that it is no longer an unmaintainable mess. Also, fixed blank spacer cells from being marked as duplicates.