-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional input parameter to include all results in the output #231
Add optional input parameter to include all results in the output #231
Conversation
@andrestoll thanks, this is great 🙏 🚀 I think it'd make sense to remove For context, |
README.md
Outdated
@@ -111,6 +111,7 @@ Power Tuner UI repository: [mattymoomoo/aws-power-tuner-ui](https://github.com/m | |||
|
|||
From most recent to oldest, with major releases in bold: | |||
|
|||
* *4.3.4* (2024-02-07): optionally include all results in output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take care of versioning docs once a new version is pushed out (usually including multiple updates) - we can just remove this for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
lambda/analyzer.js
Outdated
return findOptimalConfiguration(event); | ||
const result = findOptimalConfiguration(event); | ||
|
||
if (event.includeOutputResults) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a very minor change, mainly for consistency with the rest of the codebase, so I'd suggest something like:
if(!!event.includeOutputResults) {
just because I like to always evaluate booleans in if conditions 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
|
I've applied a couple of minor edits. Merging this now 🚀 🎉 Thank you again for contributing @andrestoll 🙏 |
By setting
includeOutputResults
to true all stats will be shown in the output.