Feature: Allow User to control their VM #124

1yam · 2024-06-12T12:21:05Z

Summary
This feature introduces new capabilities for users to manage their virtual machines (VMs) directly. The following functionalities are included:

Notify instances
Stop VMs
Reboot VMs
Erase VMs
Expire VMs
Get Logs

github-actions · 2024-06-12T12:24:00Z

Explanation:
The PR adds a new file vmclient.py to the project. This file includes a class VmClient that interacts with a virtual machine via HTTP requests. The class has methods to perform various operations on the virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine. This level of complexity is suitable for a 'RED' review as it involves adding new functionality and modifying existing code, which may require a deep understanding of the project architecture.

Highlights:

Addition of a new file vmclient.py
Addition of a new class VmClient
Implementation of various methods for interacting with a virtual machine

Marksdown:

### Categorization: RED

#### New File: vmclient.py
The PR adds a new file `vmclient.py`. This file includes a class `VmClient` that interacts with a virtual machine via HTTP requests.

#### New Class: VmClient
The PR adds a new class `VmClient`. This class has methods to perform various operations on the virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine.

#### Implementation of methods for interacting with a virtual machine
The PR implements various methods for interacting with a virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine.

The response ends with the categorization ('RED'), followed by the highlights and markdown formatting.

codecov · 2024-06-12T14:04:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@214db7c). Learn more about missing BASE report.
Report is 3 commits behind head on main.

❗ Current head c6c8cab differs from pull request most recent head 2b3b63f

Please upload reports for the commit 2b3b63f to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage        ?   84.15%           
=======================================
  Files           ?       27           
  Lines           ?     1130           
  Branches        ?      188           
=======================================
  Hits            ?      951           
  Misses          ?      176           
  Partials        ?        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hoh

Left a few comments.

My main remarks are on changing the pattern from callbacks to async generator, and to add typing annotation.

pyproject.toml

src/aleph/sdk/client/vmclient.py

github-actions · 2024-06-19T10:53:47Z

Failed to retrieve llama text: POST 504:

504 Gateway Time-out

The server didn't respond in time.

src/aleph/sdk/client/vmclient.py

hoh · 2024-06-19T13:16:50Z

Can you add tests on the new code ?

One place hardcoded `http://`, the other one `https://`.

…l use localhost as domain

Fix: extracts domain from node url instead of sending url Fix: using vmclient sessions in get_logs instead of creating new one

fix: isort issue Fix: mypy issue Fix: black Fix: isort

Fix Fix: using real path server instead of fake server for test Fix: create playload

Psycojoker · 2024-06-25T13:58:58Z

Isn't this whole PR missing any form of documentation '-'?

Else tests were breaking.

When "using bundled libsecp256k1", the setup using `/tmp/venv/bin/hatch run testing:test` fails to proceed on Python 3.12. That library `secp256k1` has been unmaintained for more than 2 years now (0.14.0, Nov 6, 2021), and seems to not support Python 3.12. The error in the logs: ``` File "/tmp/pip-build-env-ye8d6ort/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj cmd_obj = self.command_obj[command] = klass(self) ^^^^^^^^^^^ TypeError: 'NoneType' object is not callable [end of output] ``` See failing CI run: https://github.com/aleph-im/aleph-sdk-python/actions/runs/9613634583/job/26516767722

tests/unit/aleph_vm_authentication.py

src/aleph/sdk/client/vmclient.py

Co-authored-by: Olivier Le Thanh Duong <[email protected]>

olethanh

Please wait before merging. I have encountered a few bug while testing them again the CRN.
I will provide fix for them

src/aleph/sdk/client/vmclient.py

tests/unit/test_vmclient.py

src/aleph/sdk/client/vmclient.py

* Problem: A user cannot initialize an already created confidential VM. Solution: Implement `VmConfidentialClient` class to be able to initialize and interact with confidential VMs. * Problem: Auth was not working Corrections: * Measurement type returned was missing field needed for validation of measurements * Port number was not handled correctly in authentifaction * Adapt to new auth protocol where domain is moved to the operation field (While keeping compat with the old format) * Get measurement was not working since signed with the wrong method * inject_secret was not sending a json * Websocked auth was sending a twice serialized json * update 'vendorized' aleph-vm auth file from source Co-authored-by: Olivier Le Thanh Duong <[email protected]>

olethanh

I have done the modification in the andres-feature-implement_confidential_vm_initialization branch and merge dinto this one.

For me we can merge this PR. there are still some possible amelioration on the test and doc but these can be done in a sparate PR

Psycojoker · 2024-07-04T20:55:52Z

there are still some possible amelioration on the test and doc but these can be done in a separate PR

Have you open a clickup ticket for that?

olethanh · 2024-07-05T10:07:49Z

@Psycojoker https://app.clickup.com/24395970/v/l/6-901502681758-1

github-actions bot added the RED This PR is complex and may require more time to review. label Jun 12, 2024

1yam mentioned this pull request Jun 12, 2024

Feature: Instances operator commands aleph-im/aleph-client#214

Closed

hoh reviewed Jun 12, 2024

View reviewed changes

1yam force-pushed the 1yam-vm-client branch from 08ff14d to c6c8cab Compare June 13, 2024 14:46

1yam marked this pull request as draft June 13, 2024 15:42

hoh force-pushed the 1yam-vm-client branch from c6c8cab to d17e264 Compare June 14, 2024 15:57

1yam force-pushed the 1yam-vm-client branch from 2b3b63f to f067b7f Compare June 19, 2024 10:27

Feature: VmClient

f771d21

1yam force-pushed the 1yam-vm-client branch from f067b7f to f771d21 Compare June 19, 2024 10:32

1yam marked this pull request as ready for review June 19, 2024 10:37

1yam requested a review from hoh June 19, 2024 10:37

hoh reviewed Jun 19, 2024

View reviewed changes

src/aleph/sdk/client/vmclient.py Outdated Show resolved Hide resolved

src/aleph/sdk/client/vmclient.py Outdated Show resolved Hide resolved

hoh and others added 8 commits June 19, 2024 16:56

Fix: Protocol (http/https) should not be hardcoded.

ac78d53

One place hardcoded `http://`, the other one `https://`.

Fix: There was no test for notify_allocation().

5672776

WIP: Copy authentication functions from aleph-vm

301814a

Fix: vm client sessions wasn't close + authentifications for test wil…

9abb642

…l use localhost as domain

Add: Unit test for {perform_operation, stop, reboot, erase, expire}

6860015

Refactor: logs didn't need to generate full header

52faf6e

Fix: extracts domain from node url instead of sending url Fix: using vmclient sessions in get_logs instead of creating new one

Add: get_logs test

328e087

Fix: black in aleph_vm_authentification.py

5c61b9b

fix: isort issue Fix: mypy issue Fix: black Fix: isort

1yam force-pushed the 1yam-vm-client branch from 2994b07 to 5c61b9b Compare June 19, 2024 17:39

Fix: fully remove _generate_header call in get_logs

a30f690

Fix Fix: using real path server instead of fake server for test Fix: create playload

1yam force-pushed the 1yam-vm-client branch from 4bf31be to a30f690 Compare June 19, 2024 18:01

1yam added 2 commits June 19, 2024 20:02

Fix: black issue

fa998ae

Fix: test fix workflow

49c81b5

hoh and others added 8 commits June 27, 2024 12:28

Fix: Newer aleph-message requires InstanceEnvironment

5162096

Else tests were breaking.

Fix: Qemu was not the default hypervisor for instances.

65a0dfe

doc(README): command to launch tests was incorrect

93bffa9

Refactor: create and sign playload goes to utils and some fix

b53505d

Fix: linting issue

3c66af0

Fix: mypy issue

0c62cd5

fix: black

0fab7c3

1yam mentioned this pull request Jul 1, 2024

Feature: Operator command for instance aleph-im/aleph-client#225

Merged

Psycojoker added 3 commits July 2, 2024 15:38

feat: use bytes_from_hex where it makes sens

5380da5

chore: use ruff new CLI api

fc1e6af

feat: add unit tests for authentication mechanisms of VmClient

2f180e3

Psycojoker reviewed Jul 3, 2024

View reviewed changes

tests/unit/aleph_vm_authentication.py Outdated Show resolved Hide resolved

fix: debug code remove

d271038

olethanh changed the title ~~Feature: Allow User to control there VM~~ Feature: Allow User to control their VM Jul 3, 2024

olethanh requested changes Jul 4, 2024

View reviewed changes

src/aleph/sdk/client/vmclient.py Outdated Show resolved Hide resolved

1yam and others added 2 commits July 4, 2024 11:00

Update vmclient.py

5e88161

Co-authored-by: Olivier Le Thanh Duong <[email protected]>

Fix: update unit test to use stream_logs endpoint instead of logs

d9b1892

olethanh self-requested a review July 4, 2024 09:54

olethanh requested changes Jul 4, 2024

View reviewed changes

olethanh reviewed Jul 4, 2024

View reviewed changes

src/aleph/sdk/client/vmclient.py Outdated Show resolved Hide resolved

nesitor requested changes Jul 4, 2024

View reviewed changes

tests/unit/test_vmclient.py Outdated Show resolved Hide resolved

src/aleph/sdk/client/vmclient.py Outdated Show resolved Hide resolved

olethanh self-requested a review July 4, 2024 20:33

olethanh approved these changes Jul 4, 2024

View reviewed changes

nesitor approved these changes Jul 4, 2024

View reviewed changes

olethanh merged commit e1704ef into main Jul 5, 2024
14 of 15 checks passed

Psycojoker deleted the 1yam-vm-client branch July 24, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Allow User to control their VM #124

Feature: Allow User to control their VM #124

1yam commented Jun 12, 2024 •

edited

Loading

github-actions bot commented Jun 12, 2024

codecov bot commented Jun 12, 2024 •

edited

Loading

hoh left a comment

github-actions bot commented Jun 19, 2024

hoh commented Jun 19, 2024

Psycojoker commented Jun 25, 2024

olethanh left a comment

olethanh left a comment

Psycojoker commented Jul 4, 2024

olethanh commented Jul 5, 2024

Feature: Allow User to control their VM #124

Feature: Allow User to control their VM #124

Conversation

1yam commented Jun 12, 2024 • edited Loading

github-actions bot commented Jun 12, 2024

codecov bot commented Jun 12, 2024 • edited Loading

Codecov Report

hoh left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 19, 2024

504 Gateway Time-out

hoh commented Jun 19, 2024

Psycojoker commented Jun 25, 2024

olethanh left a comment

Choose a reason for hiding this comment

olethanh left a comment

Choose a reason for hiding this comment

Psycojoker commented Jul 4, 2024

olethanh commented Jul 5, 2024

1yam commented Jun 12, 2024 •

edited

Loading

codecov bot commented Jun 12, 2024 •

edited

Loading