-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file_path param to download_file()
to directly download files to disk
#115
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 83.67% 84.17% +0.50%
==========================================
Files 27 27
Lines 1084 1131 +47
Branches 181 188 +7
==========================================
+ Hits 907 952 +45
- Misses 175 176 +1
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
@hoh I think codecov is incorrectly configured. It currently also measures test file coverage... Which doesn't make sense. |
Why not ? Tests that don't run do not make sense. |
Because I just added some cleanup checks after downloading to the file, in order to check the automatic directory and file creation every time correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach for dual use of the download_file
seems very confusing, see my comment on the topic.
This branch is re-implementing in it a lot of patterns that are already covered by the Python standard library.
…o disk instead of keeping them in memory.
…ng file download; Return path of the saved_to
54288ba
to
69b9cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Concerns have been addressed, reviewed by Lyam.
Instead of keeping them in memory. Addresses #37.