Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom domains attribute #66 #69

Closed
wants to merge 1 commit into from
Closed

add custom domains attribute #66 #69

wants to merge 1 commit into from

Conversation

aliel
Copy link
Member

@aliel aliel commented Jun 3, 2023 •
edited by hoh
Loading

Solves #67

@aliel aliel requested a review from hoh June 3, 2023 10:40
hoh
hoh approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pretty simple, but I don't see reasons to make it more complex.

@hoh hoh requested a review from odesenfans June 5, 2023 08:05
@hoh
Copy link
Member

hoh commented Jun 12, 2023

Our plan is to use aggregate messages instead of this approach.

@hoh hoh closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoh hoh hoh approved these changes

@odesenfans odesenfans Awaiting requested review from odesenfans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliel @hoh