-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: account managment and sol #281
Open
1yam
wants to merge
10
commits into
master
Choose a base branch
from
1yam-account-managment-and-sol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+463
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Psycojoker
reviewed
Oct 3, 2024
Psycojoker
reviewed
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 38.56% 38.14% -0.42%
==========================================
Files 18 18
Lines 1932 2097 +165
Branches 335 250 -85
==========================================
+ Hits 745 800 +55
- Misses 1151 1260 +109
- Partials 36 37 +1 ☔ View full report in Codecov by Sentry. |
philogicae
force-pushed
the
1yam-account-managment-and-sol
branch
from
October 9, 2024 14:59
b9c349c
to
c96fc18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow usage of multiple chain more easily on aleph-client
Related ClickUp, GitHub or Jira tickets : ALEPH-51
Self proofreading checklist
Documentation
The documentation regarding the impacted features is available on:
The changes in the documentation are available here:
Changes
We now handle the new account handling (also added handler in the instance creations)
How to test
Print screen / video
Notes
Most of the change is handle by the change in aleph-sdk-python, expect for payment handling so also need testing on aleph
instance create