Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: account managment and sol #281

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Sep 30, 2024

This PR allow usage of multiple chain more easily on aleph-client

Related ClickUp, GitHub or Jira tickets : ALEPH-51

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

The documentation regarding the impacted features is available on:

Not done yet

The changes in the documentation are available here:

Not done yet

Changes

We now handle the new account handling (also added handler in the instance creations)

How to test

pip install git+https://github.com/aleph-im/aleph-sdk-python.git@1yam-solana-acount
aleph account create # add new account
aleph account list # list all linked account
aleph account config # add account only to the config.json
aleph account update # update specific account

Print screen / video

image
image
image

Notes

Most of the change is handle by the change in aleph-sdk-python, expect for payment handling so also need testing on aleph instance create

Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@philogicae
Copy link
Member

philogicae commented Oct 7, 2024

Updated commands

image

Helpers

image

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 31.19658% with 161 lines in your changes missing coverage. Please review.

Project coverage is 38.14%. Comparing base (bc41292) to head (c96fc18).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/account.py 36.11% 81 Missing and 11 partials ⚠️
src/aleph_client/commands/instance/__init__.py 12.24% 43 Missing ⚠️
src/aleph_client/utils.py 20.00% 12 Missing ⚠️
src/aleph_client/commands/utils.py 21.42% 11 Missing ⚠️
src/aleph_client/commands/message.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   38.56%   38.14%   -0.42%     
==========================================
  Files          18       18              
  Lines        1932     2097     +165     
  Branches      335      250      -85     
==========================================
+ Hits          745      800      +55     
- Misses       1151     1260     +109     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae self-assigned this Oct 9, 2024
@philogicae philogicae removed their request for review October 9, 2024 14:47
@philogicae philogicae force-pushed the 1yam-account-managment-and-sol branch from b9c349c to c96fc18 Compare October 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants