Bugfixed/further cli functionality #147
Conversation
There was a problem hiding this comment.
LGTM, minor changes required. Try to use https://black.readthedocs.io/en/stable/ to format all the modified files according to the style as the repository is formatted in
| api_server: str = settings.API_HOST, | ||
| content, | ||
| session: Optional[ClientSession] = None, | ||
| api_server: str = settings.API_HOST, |
There was a problem hiding this comment.
Please use https://black.readthedocs.io/en/stable/ instead for auto-formatting code.
| use_latest: bool, | ||
| reproducible: bool, | ||
| internet: bool, | ||
| aleph_api: bool, |
There was a problem hiding this comment.
You could assign default values here the same as the hardcoded ones before:
| aleph_api: bool, | |
| aleph_api: bool = True, |
| private_key_file: Optional[Path] = typer.Option( | ||
| settings.PRIVATE_KEY_FILE, help=help_strings.PRIVATE_KEY_FILE | ||
| ), | ||
| debug: bool = False, |
There was a problem hiding this comment.
Same goes for formatting here
| use_latest: bool = typer.Option(True, help='Use latest version of the base docker image'), | ||
| reproducible: bool = typer.Option(False, help=' (Not Implemented)--> Check output is same for other nodes'), | ||
| internet: bool = typer.Option(True, help='VM should have internet connectivity'), | ||
| aleph_api: bool = typer.Option(True, help='VM needs access to Aleph messages AP'), |
There was a problem hiding this comment.
| aleph_api: bool = typer.Option(True, help='VM needs access to Aleph messages AP'), | |
| aleph_api: bool = typer.Option(True, help='VM needs access to Aleph messages'), |
|
|
||
|
|
||
| if __name__ == '__main __': | ||
| unittest.main() |
There was a problem hiding this comment.
Please revert changes here, we don't use unittest
|
Changes here need to be reimplemented in aleph-sdk-python. Closed. |
Everything related to the CLI should be implemented in |
|
Superseded by aleph-im/aleph-sdk-python#77 and a future PR including the new parameters in the CLI. |
Fixed
Descriptions for the CLI parameters:
--allow-amend: Whether the deployed VM image may be changed and deployed on the same URL
--use-latest: Whether to use latest version of the base docker image
--reproducible: Not Implemented
--internet: Whether the VM should have internet connectivity
--aleph_api: Whether the VM needs access to Aleph messages API