Add stringData to Secret's sensitive fields #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adphi <[email protected]>
|
@Adphi could you please reference the original issue (if any) in a comment? or give a bit more context? Cheers. |
|
@alekc I added context in the description. I can create an issue instead if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, if no sensitive fields are provided in the resource, the controller will mark the Secrets' data field as sensitive.
But often, it is way less work to provide data through the stringData field that accept non base64 encoded values.
The provider display their content in plain text during the diff.
This pull request add the stringData field to the default ones.