share/containers/, .github/workflows/: Don't make(1) twice

It was being done so that the second one prints errors without races.
However, the same thing can be achieved by passing -Orecurse to make(1).

And this makes the logs even more readable, since there's no racy output
at all.

Fixes: 97f79e3 ("CI: Make build logs more readable")
Link: <shadow-maint#702>
Link: <nginx/unit#1123>
Acked-by: Iker Pedrosa <[email protected]>
Cc: Andrew Clayton <[email protected]>
Cc: Konstantin Pavlov <[email protected]>
Cc: Dylan Arbour <https://github.com/arbourd>
Signed-off-by: Alejandro Colomar <[email protected]>

.github/workflows/static-code-analysis.yml

@@ -32,10 +32,7 @@ jobs:
     - name: Build shadow-utils
       run: |
         PROCESSORS=$(/usr/bin/getconf _NPROCESSORS_ONLN)
-        make -kj$PROCESSORS || true
-
-    - name: Check build errors
-      run: make
+        make -Orecurse -j$PROCESSORS
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v2

share/containers/alpine.dockerfile

@@ -9,8 +9,7 @@ COPY ./ /usr/local/src/shadow/
 WORKDIR /usr/local/src/shadow/
 
 RUN ./autogen.sh --without-selinux --disable-man --disable-nls --with-yescrypt
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
 RUN make check
 RUN make install
 

share/containers/debian.dockerfile

@@ -15,8 +15,7 @@ COPY ./ /usr/local/src/shadow/
 WORKDIR /usr/local/src/shadow/
 
 RUN ./autogen.sh --without-selinux --enable-man --with-yescrypt
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
 RUN make check
 RUN make install
 

share/containers/fedora.dockerfile

@@ -12,8 +12,7 @@ RUN ./autogen.sh --enable-shadowgrp --enable-man --with-audit \
         --with-sha-crypt --with-bcrypt --with-yescrypt --with-selinux \
         --without-libpam --enable-shared --without-libbsd \
         --with-group-name-max-length=32 --enable-lastlog --enable-logind=no
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
 RUN make check
 RUN make install