Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to tensor v2 #2015

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add tests to tensor v2 #2015

merged 2 commits into from
Oct 23, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Oct 23, 2024

Summary by Sourcery

Add a new test case for the ToTensorV2 transformation to ensure images and masks are correctly converted to torch.Tensor, and remove the unused 'apply_to_images' method from the transforms module.

Enhancements:

  • Remove the 'apply_to_images' method from the ToTensorV2 class in the transforms module.

Tests:

  • Add new test case 'test_to_tensor_v2_images_masks' to verify the conversion of images and masks to torch.Tensor using ToTensorV2.

Copy link
Contributor

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This PR adds test coverage for the ToTensorV2 transform's handling of multiple data types (images and masks) and removes a redundant method. The changes focus on verifying that the transform correctly converts numpy arrays to PyTorch tensors for both single and multiple inputs.

Sequence diagram for test_to_tensor_v2_images_masks

sequenceDiagram
    actor Tester
    participant Transform as A.Compose([ToTensorV2(p=1)])
    participant Image as SQUARE_UINT8_IMAGE
    participant Mask as np.random.randint
    participant Transformed

    Tester->>Transform: Create transform
    Tester->>Image: Prepare image
    Tester->>Mask: Prepare mask
    Tester->>Transform: Call transform with image, mask, masks, images
    Transform->>Transformed: Return transformed data
    Tester->>Transformed: Assert transformed['image'] is torch.Tensor
    Tester->>Transformed: Assert transformed['mask'] is torch.Tensor
    Tester->>Transformed: Assert all transformed['masks'] are torch.Tensor
    Tester->>Transformed: Assert all transformed['images'] are torch.Tensor
Loading

Class diagram for ToTensorV2 transform changes

classDiagram
    class ToTensorV2 {
        +apply(img: np.ndarray, **params: Any) torch.Tensor
        +apply_to_mask(mask: np.ndarray, **params: Any) torch.Tensor
    }
    note for ToTensorV2 "Removed method: apply_to_images(images: list[np.ndarray], **params: Any) list[torch.Tensor]"
Loading

File-Level Changes

Change Details Files
Added new test case for ToTensorV2 transform with multiple input types
  • Added test to verify transformation of single image and mask
  • Added test to verify transformation of multiple images and masks
  • Validates that all outputs are correctly converted to torch.Tensor type
tests/test_pytorch.py
Removed redundant apply_to_images method
  • Removed method that was a simple list comprehension of the apply method
albumentations/pytorch/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR removes the apply_to_images method without explanation. Please provide context for why this method is being removed and confirm this won't break existing functionality.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tests/test_pytorch.py Show resolved Hide resolved
tests/test_pytorch.py Show resolved Hide resolved
tests/test_pytorch.py Show resolved Hide resolved
tests/test_pytorch.py Show resolved Hide resolved
tests/test_pytorch.py Show resolved Hide resolved
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (b1a79c2) to head (2b10b9f).
Report is 227 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2015       +/-   ##
=========================================
+ Coverage      0   90.32%   +90.32%     
=========================================
  Files         0       47       +47     
  Lines         0     7558     +7558     
=========================================
+ Hits          0     6827     +6827     
- Misses        0      731      +731     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ternaus ternaus merged commit 99701a2 into main Oct 23, 2024
16 checks passed
@ternaus ternaus deleted the add_tests_to_tensor_v2 branch October 23, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant