Remove scikit image

[ternaus]

Fixes: #1895

Summary by Sourcery

Remove the dependency on scikit-image by refactoring the superpixels function to use numpy operations instead of regionprops, and update the setup.py to reflect this change.

Enhancements:

• Refactor the superpixels function to remove the dependency on scikit-image by replacing regionprops with numpy operations.

Build:

• Remove scikit-image from the list of installation requirements in setup.py.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the dependency on scikit-image and modifies the superpixels function to use numpy operations instead. The changes aim to optimize the implementation and reduce external dependencies.

Entity relationship diagram for setup.py dependencies

erDiagram
    INSTALL_REQUIRES {
        string numpy
        string scipy
        string PyYAML
        string typing-extensions
        string pydantic
    }
    note for INSTALL_REQUIRES "Removed scikit-image dependency"

Loading

Class diagram for the updated superpixels function

classDiagram
    class SuperpixelsFunction {
        - skimage.measure.regionprops(segments + 1, intensity_image=image[..., c])
        + np.unique(segments)
        + np.mean(image_sp_c[mask])
    }
    note for SuperpixelsFunction "Replaced scikit-image operations with numpy operations"

Loading

File-Level Changes

Change	Details	Files
Refactor superpixels function to remove scikit-image dependency	Replace skimage.measure.regionprops with custom numpy operations Implement mean intensity calculation using numpy Modify the loop to iterate over unique segment labels Update the logic for replacing pixel values in segments	albumentations/augmentations/functional.py
Remove scikit-image from project dependencies	Remove 'scikit-image>=0.21.0' from INSTALL_REQUIRES list Reformat the INSTALL_REQUIRES list for better readability	setup.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

• Great initiative in removing the scikit-image dependency. To ensure the change doesn't introduce any regressions, please provide information on the testing performed, especially comparing the output of the new implementation with the old one across various input types and edge cases.
• Consider adding performance benchmarks comparing the new implementation to the old one. This information would be valuable for users and could highlight the benefits of this change.
• Some comments in the superpixels function (e.g., about 'segments+1') are no longer relevant to the new implementation. Consider updating or removing these to reflect the current approach.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}