Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix affine balanxced scale 1 #2005

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Fix affine balanxced scale 1 #2005

merged 3 commits into from
Oct 21, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Oct 21, 2024

Fix: #2004

Summary by Sourcery

Fix the Affine transformation's scale handling to support both float and tuple inputs, ensuring balanced scaling is applied correctly. Add tests to verify the correct behavior of the get_scale method with different configurations. Update the pre-commit configuration to use the latest mypy version.

Bug Fixes:

  • Fix the handling of scale values in the Affine transformation to correctly process both float and tuple inputs, ensuring balanced scaling is applied appropriately.

Tests:

  • Add comprehensive tests for the get_scale method in the Affine transformation to verify correct behavior with various scale configurations, including balanced scaling and keeping aspect ratio.

Chores:

  • Update the pre-commit configuration to use mypy version v1.12.1.

Copy link
Contributor

sourcery-ai bot commented Oct 21, 2024

Reviewer's Guide by Sourcery

This pull request fixes an issue with the Affine transformation in the albumentations library, specifically addressing the balanced scale functionality. The changes improve the handling of scale parameters, add type checking, and include new test cases to ensure correct behavior.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored the get_scale method in the Affine transformation class
  • Added support for single float values in the scale parameter
  • Improved type checking for scale values
  • Restructured the logic for balanced scale calculations
  • Added error handling for invalid scale types
albumentations/augmentations/geometric/transforms.py
Added comprehensive test cases for the get_scale method
  • Created parametrized tests for various scale, keep_ratio, and balanced_scale combinations
  • Added specific tests for balanced scale behavior
  • Included tests for keep_ratio functionality
tests/functional/test_affine.py
Updated pre-commit configuration
  • Upgraded mypy version from v1.12.0 to v1.12.1
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit a63a98a into main Oct 21, 2024
14 checks passed
@ternaus ternaus deleted the fix_affine_balanxced_scale_1 branch October 21, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Affine] Unable to run Scale = 1.0 without raising error
1 participant