-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix affine balanxced scale 1 #2005
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue with the Affine transformation in the albumentations library, specifically addressing the balanced scale functionality. The changes improve the handling of scale parameters, add type checking, and include new test cases to ensure correct behavior. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fix: #2004
Summary by Sourcery
Fix the Affine transformation's scale handling to support both float and tuple inputs, ensuring balanced scaling is applied correctly. Add tests to verify the correct behavior of the get_scale method with different configurations. Update the pre-commit configuration to use the latest mypy version.
Bug Fixes:
Tests:
Chores: