Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scikit image #1988

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Remove scikit image #1988

merged 6 commits into from
Oct 10, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Oct 10, 2024

Summary by Sourcery

Remove the dependency on scikit-image by implementing custom functions for histogram matching and superpixel segmentation using OpenCV and NumPy. Update related tests to validate the new implementations.

New Features:

  • Introduce a custom implementation of histogram matching using OpenCV and NumPy, replacing the previous dependency on scikit-image.

Enhancements:

  • Replace the scikit-image SLIC superpixel segmentation with a custom implementation using OpenCV and NumPy.
  • Add a custom label function for connected region labeling, mimicking scikit-image's label function using OpenCV.

Tests:

  • Add tests for the new histogram matching function to ensure it produces results comparable to the scikit-image implementation.

Copy link
Contributor

sourcery-ai bot commented Oct 10, 2024

Reviewer's Guide by Sourcery

This pull request removes the dependency on scikit-image by implementing custom functions for histogram matching and connected component labeling using OpenCV and NumPy. The changes primarily affect the domain adaptation and superpixel functionality in the Albumentations library.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced scikit-image's histogram matching with a custom implementation
  • Implemented a custom match_histograms function using OpenCV and NumPy
  • Updated the apply_histogram function to use the new custom implementation
  • Added a helper function _match_cumulative_cdf for histogram matching
  • Updated tests to compare the custom implementation with scikit-image's version
albumentations/augmentations/domain_adaptation/functional.py
tests/test_domain_adaptation.py
Replaced scikit-image's SLIC superpixel implementation with a custom one
  • Implemented a custom slic function using OpenCV and NumPy
  • Updated the superpixels function to use the new custom implementation
  • Removed references to scikit-image in the Superpixels class documentation
albumentations/augmentations/functional.py
albumentations/augmentations/transforms.py
Implemented a custom connected component labeling function
  • Added a new label function in the dropout functional module
  • Updated the MaskDropout transform to use the new custom labeling function
albumentations/augmentations/dropout/functional.py
albumentations/augmentations/dropout/mask_dropout.py
Updated imports and removed unused imports
  • Removed import of match_histograms from skimage.exposure
  • Removed import of NUM_MULTI_CHANNEL_DIMENSIONS
  • Added import of uint8_io from albucore
albumentations/augmentations/domain_adaptation/functional.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

albumentations/augmentations/functional.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
@ternaus ternaus merged commit d06a0e3 into main Oct 10, 2024
14 checks passed
@ternaus ternaus deleted the remove_scikit_image branch October 10, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant