Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template transform moved to Domain Adaptation #1982

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Oct 8, 2024

Summary by Sourcery

Relocate the TemplateTransform class from the general augmentations module to the domain adaptation module, reflecting a structural change in the code organization to align with its functional purpose.

Enhancements:

  • Move the TemplateTransform class from the general augmentations module to the domain adaptation module, indicating a reorganization of the codebase to better categorize transformations.

Copy link
Contributor

sourcery-ai bot commented Oct 8, 2024

Reviewer's Guide by Sourcery

This pull request moves the TemplateTransform class from the 'transforms.py' file to the 'domain_adaptation/transforms.py' file. The TemplateTransform class has been updated with some modifications to its functionality and documentation.

Class diagram for TemplateTransform changes

classDiagram
    class TemplateTransform {
        +np.ndarray | list[np.ndarray] templates
        +ScaleFloatType img_weight
        +Compose | BasicTransform | None template_transform
        +str | None name
        +bool | None always_apply
        +float p
        +apply(np.ndarray img, np.ndarray template, float img_weight, **params) np.ndarray
        +get_params() dict[str, float]
        +get_params_dependent_on_data(dict[str, Any] params, dict[str, Any] data) dict[str, Any]
        +is_serializable() bool
        +to_dict_private() dict[str, Any]
    }
    TemplateTransform : -ZeroOneRangeType template_weight (deprecated)
    TemplateTransform : +Field deprecated="Template_weight is deprecated. Computed automatically as (1 - img_weight)"
Loading

File-Level Changes

Change Details Files
Moved TemplateTransform class to domain adaptation module
  • Removed TemplateTransform from transforms.py
  • Added TemplateTransform to domain_adaptation/transforms.py
  • Updated import statements in domain_adaptation/transforms.py
albumentations/augmentations/transforms.py
albumentations/augmentations/domain_adaptation/transforms.py
Modified TemplateTransform class implementation
  • Removed template_weight parameter
  • Updated blending formula to use only img_weight
  • Simplified apply method
  • Updated documentation to reflect changes
albumentations/augmentations/domain_adaptation/transforms.py
Updated TemplateTransform class documentation
  • Removed references to template_weight
  • Updated mathematical formulation
  • Added new example for template transform with additional transforms
albumentations/augmentations/domain_adaptation/transforms.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit 3680ee8 into main Oct 8, 2024
17 checks passed
@ternaus ternaus deleted the update_template_transform branch October 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant