-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template transform moved to Domain Adaptation #1982
Conversation
Reviewer's Guide by SourceryThis pull request moves the TemplateTransform class from the 'transforms.py' file to the 'domain_adaptation/transforms.py' file. The TemplateTransform class has been updated with some modifications to its functionality and documentation. Class diagram for TemplateTransform changesclassDiagram
class TemplateTransform {
+np.ndarray | list[np.ndarray] templates
+ScaleFloatType img_weight
+Compose | BasicTransform | None template_transform
+str | None name
+bool | None always_apply
+float p
+apply(np.ndarray img, np.ndarray template, float img_weight, **params) np.ndarray
+get_params() dict[str, float]
+get_params_dependent_on_data(dict[str, Any] params, dict[str, Any] data) dict[str, Any]
+is_serializable() bool
+to_dict_private() dict[str, Any]
}
TemplateTransform : -ZeroOneRangeType template_weight (deprecated)
TemplateTransform : +Field deprecated="Template_weight is deprecated. Computed automatically as (1 - img_weight)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Relocate the TemplateTransform class from the general augmentations module to the domain adaptation module, reflecting a structural change in the code organization to align with its functional purpose.
Enhancements: