Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for contigous masks #1975

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Add tests for contigous masks #1975

merged 3 commits into from
Oct 8, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Oct 7, 2024

Added tests, just in case for:
#1972

Summary by Sourcery

Add a test case to verify the behavior of the ToTensorV2 transformation when applied to non-contiguous arrays with a RandomRotate90 transformation.

Tests:

  • Add a test for the ToTensorV2 transformation on a non-contiguous array with a RandomRotate90 transformation.

Copy link
Contributor

sourcery-ai bot commented Oct 8, 2024

Reviewer's Guide by Sourcery

This pull request adds a new test case to ensure that the ToTensorV2 transformation works correctly with non-contiguous arrays when combined with the RandomRotate90 augmentation. The test is added to address a potential issue reported in the Albumentations library.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new test case for ToTensorV2 transformation with non-contiguous arrays
  • Created a new test function 'test_to_tensor_v2_on_non_contiguous_array_with_random_rotate90'
  • Defined a composition of RandomRotate90 and ToTensorV2 transformations
  • Generated random image and mask data for testing
  • Applied the transformations to the generated data
tests/test_pytorch.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tests/test_pytorch.py Outdated Show resolved Hide resolved
tests/test_pytorch.py Show resolved Hide resolved
@ternaus ternaus merged commit ef227fd into main Oct 8, 2024
17 checks passed
@ternaus ternaus deleted the add_tests_for_contigous_masks branch October 8, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant