Add pydantic #1605
Closed
Add pydantic #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ternaus - I've reviewed your changes and they look great!
General suggestions:
- Consider simplifying the implementation by integrating configuration directly into the transformation classes to reduce complexity.
- Ensure comprehensive test coverage for the new configuration models, including their custom validators and edge cases.
- Review the relationship between
quality_lowerandquality_upperinImageCompressionConfigto ensure it's validated within the config class. - Add unit tests for the new
ImageCompressionTypeenum to verify serialization and deserialization.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟡 Complexity: 1 issue found
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Dipet
reviewed
Mar 23, 2024
| always_apply: bool = False, | ||
| p: float = 0.5, | ||
| ): | ||
| config = BaseTransformConfig(always_apply=always_apply, p=p) |
There was a problem hiding this comment.
This must be inside BasicTransform.__init__
| raise ValueError(f"Grid dimensions must be positive integers. Current grid dimensions: [{n}, {m}]") | ||
|
|
||
| self.grid = grid | ||
| config = RandomGridShuffleConfig(grid=grid, always_apply=always_apply, p=p) |
There was a problem hiding this comment.
Maybe we can do this using metcaclasses...
Look SerializableMeta as an example https://github.com/albumentations-team/albumentations/blob/main/albumentations/core/serialization.py#L44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.