Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChromaticAberration #1589

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Add ChromaticAberration #1589

merged 7 commits into from
Mar 18, 2024

Conversation

mrsmrynk
Copy link
Contributor

Hi @albumentations-team,

here's my PR with the ChromaticAberration transform, as discussed in [#1386]:

Left: Original, Middle: Chromatic aberration (default args, mode="green_purple"), Right: Chromatic aberration (default args, mode="red_blue")
(Image is from our internal mobile mapping dataset)

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrsmrynk - I've reviewed your changes and they look great!

General suggestions:

  • Consider adding more detailed documentation or examples on how the different distortion levels and modes affect the resulting images.
  • Review the randomness introduced by the distortion parameters to ensure it aligns with the intended use cases and provides a consistent user experience.
  • Ensure that the handling of different modes, especially the 'random' mode, is clear and well-documented to avoid confusion.
  • Evaluate the performance impact of the new transform, particularly the necessity of certain checks like non_rgb_warning in performance-critical paths.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

albumentations/augmentations/transforms.py Show resolved Hide resolved
albumentations/augmentations/transforms.py Outdated Show resolved Hide resolved
albumentations/augmentations/transforms.py Show resolved Hide resolved
albumentations/augmentations/functional.py Show resolved Hide resolved
@mrsmrynk
Copy link
Contributor Author

Removed an unused import.
Ruff checks should pass now :)

@ternaus
Copy link
Collaborator

ternaus commented Mar 18, 2024

Thank you for your contribution!

By the way, would you or your company consider becoming a sponsor for the project?

https://github.com/sponsors/albumentations-team

@ternaus ternaus merged commit f52c8db into albumentations-team:main Mar 18, 2024
17 checks passed
@ternaus ternaus mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants